Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generate interfaces script #6031

Merged
merged 2 commits into from
Aug 1, 2017
Merged

Fix generate interfaces script #6031

merged 2 commits into from
Aug 1, 2017

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Jul 31, 2017 •
edited
Loading

Q A
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Deprecations? n
Spec Compliancy? n
Tests Added/Pass?
Fixed Tickets
License MIT
Doc PR
Dependency Changes

While looking at the CI failure in #5990, I noticed:

  • A small typo in TSPropertySignature
  • Because we now spread a bunch of common fields, generate-interfaces was creating a number of types with out of order params. It now matches what we do in generate-babel-types-docs
  • import() needs to be blacklisted similarly to super()

@existentialism existentialism added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jul 31, 2017
@mention-bot
Copy link

@existentialism, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Daniel15, @ForbesLindesay and @xtuc to be potential reviewers.

@existentialism existentialism mentioned this pull request Aug 1, 2017
Merged
@hzoo hzoo merged commit 21eeed8 into 7.0 Aug 1, 2017
@existentialism existentialism deleted the fix-generate-interfaces branch August 1, 2017 18:39
This was referenced Aug 15, 2017
Merged
Merged
hzoo pushed a commit that referenced this pull request Aug 15, 2017
@hzoo
Backport #6031 (#6112)
f4716dc 
* Backport #6031

* Backport #6031

* Rebase on master, rerun scripts

* Update flowconfig
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@existentialism @mention-bot @hzoo