Fix destructuring assignment spec violation #6986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObjectPattern should be checked in toAssignableList
xtuc
approved these changes
Dec 7, 2017
packages/babylon/src/parser/lval.js
Outdated
| @@ -150,7 +150,8 @@ export default class LValParser extends NodeUtils { | |||
| if ( | |||
| arg.type !== "Identifier" && | |||
| arg.type !== "MemberExpression" && | |||
| arg.type !== "ArrayPattern" | |||
| arg.type !== "ArrayPattern" && | |||
| arg.type !== "ObjectPattern" | |||
There was a problem hiding this comment.
We could probably transform that into a Array lookup for readability, but lgtm. Thanks for your contrib @ksashikumar
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6123/ |
|
That syntax is not allowed in the test262 test suites (https://github.com/babel/babel/pull/6986/files#diff-146d031d23e0df2adf55d70f79b7e12c) ? |
|
@xtuc That tests where whitelisted because they should have passed but they didn't. In fact the travis ci error is
|
nicolo-ribaudo
approved these changes
Dec 7, 2017
existentialism
added
PR: Bug Fix 🐛
|
@ksashikumar thanks! |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectPattern should be checked in toAssignableList
Spec: https://tc39.github.io/ecma262/#sec-destructuring-assignment
An
AssignmentRestElementis defined as... DestructuringAssignmentTarget.DestructuringAssignmentTargetisLeftHandSideExpression, which in assignment contexts can be anyAssignmentPattern(https://tc39.github.io/ecma262/#sec-destructuring-assignment), so... ObjectAssignmentPatternis a validAssignmentRestElement