Improve error message in types assert #7001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
added
the
PR: Polish 💅
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6144/ |
existentialism
force-pushed
the
improve-assert-error
branch
from
eaa129a
to
293ffee
Compare
| @@ -18,7 +18,7 @@ import is from "../../validators/is"; | |||
| function assert(type: string, node: Object, opts?: Object): void { | |||
| if (!is(type, node, opts)) { | |||
| throw new Error( | |||
| \`Expected type "\${type}" with option \${JSON.stringify(opts)}\`, | |||
| \`Expected type "\${type}" with option \${JSON.stringify(opts)}, but instead got "\${node.type}".\`, | |||
There was a problem hiding this comment.
Can you break this line like in the generated file? Otherwise we will need to make fix every time that it is recreated.
There was a problem hiding this comment.
I can for consistency sake, but the generated files are auto "prettified" via:
https://github.com/babel/babel/blob/master/packages/babel-types/scripts/utils/formatCode.js
nicolo-ribaudo
approved these changes
Dec 8, 2017
hzoo
approved these changes
Dec 9, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From our slack convo, minor but improves the error message a bit.