Better error messages when Babel fails to parse import = and export =… #7079

gs-akhan · 2017-12-20T21:09:20Z

… syntax from typescript when using babel-plugin-transform-typescript

Q	A
Fixed Issues?	#7067
Patch: Bug Fix?	No
Major: Breaking Change?	No
Minor: New Feature?	No
Tests Added + Pass?	Yes
Documentation PR
Any Dependency Changes?	No
License	MIT

The error messages displayed when Typescript's import = and export = were very less descriptive. Giving users no clue about what to do next..
Hence this messages can improve things regarding on how to fix their imports and exports in Typescript.

Detailed discussion can be found at
#7062
#7067

Thanks

… syntax from typescript when using babel-plugin-transform-typescript

babel-bot · 2017-12-20T21:36:34Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6288/

nicolo-ribaudo · 2017-12-20T21:38:01Z

Can you run make fix to format the code?

gs-akhan · 2017-12-20T21:39:11Z

Sure..

nicolo-ribaudo · 2017-12-20T21:39:30Z

Also, it would be better to split the message on multiple lines (lines should be no longer than 80 chars)

e.g.

throw buildCodeframeError(
  "bla bla bla ... .... " +
  "second line to make " +
  "them shorter"
);

gs-akhan · 2017-12-20T21:40:42Z

On its way.. :)

…

On Thu, Dec 21, 2017 at 3:09 AM, Nicolò Ribaudo ***@***.***> wrote: Also, it would be better to split the message on multiple lines (lines should be no longer than 80 chars) e.g. throw buildCodeframeError( "bla bla bla ... .... " + "second line to make " + "them shorter" ); — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7079 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFYnVl6XdpEtH1hFku5a7a-wszcDjiZnks5tCX6igaJpZM4RI9ub> .

nicolo-ribaudo · 2017-12-20T22:00:13Z

packages/babel-plugin-transform-typescript/src/index.js

@@ -205,11 +205,19 @@ export default function() {
      },

      TSImportEqualsDeclaration(path) {
-        throw path.buildCodeFrameError("`import =` is not supported.");
+        throw path.buildCodeFrameError(
+          "`import =` is not supported in Babel's Typescript parser " +


I'd use plugin instead of parser, since it is parsed correctly but not transformed.

It is not. Because If you don't use any plugins. It breaks still..

Or maybe is not supported by @babel/plugin-transform-typescript? 🤔

It is not. Because If you don't use any plugins. It breaks still..

If you don' transform it, it works. https://runkit.com/embed/bsijdhpw0mq9

Not sure either. I wish Babel could parse this to "importdeclaration = Identifier"
I could write codemod to migrate all our legacyJS files to TS. :)

Yes, let's go with is not supported by @babel/plugin-transform-typescript.

Sure.. On its way

I wish Babel could parse this to "importdeclaration = Identifier"
I could write codemod to migrate all our legacyJS files to TS. :)

Just use import identifier from "module" 😛

import = is only kept for backward compatibility, so it is "legacyTS" https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#1133-import-require-declarations

Alright Just a grammar review here before I add

throw path.buildCodeFrameError( "`import =` is not supported by @babel/plugin-transform-typescript \n" + "Please consider using " + "`import <moduleName> from '<moduleName>';` alongside " + "Typescript's --allowSyntheticDefaultImports option.", );

nicolo-ribaudo · 2017-12-20T22:01:17Z

packages/babel-plugin-transform-typescript/src/index.js

-        throw path.buildCodeFrameError("`export =` is not supported.");
+        throw path.buildCodeFrameError(
+          "`export =` is not supported in Babel's Typescript parser because " +
+            "there is no valid ES6 implementation for it.\nPlease consider using `export <value>;`.",


Isn't export = more like export default <value> than export <value>? (I don't use TS very much, so I'm not sure)

Yes. Basically you could only export one object earlier. Now support
export default <value> & export <value>

nicolo-ribaudo · 2017-12-20T22:36:38Z

packages/babel-plugin-transform-typescript/src/index.js

@@ -205,11 +205,19 @@ export default function() {
      },

      TSImportEqualsDeclaration(path) {
-        throw path.buildCodeFrameError("`import =` is not supported.");
+        throw path.buildCodeFrameError(
+          "`import =` is not supported by @babel/plugin-transform-typescript \n" +


You can remove the trailing space (the other message is ok)

@nicolo-ribaudo it was there earlier too. If I remove it on terminal the words look very closely attached.

Oh, I meant before \n

nicolo-ribaudo

👍

gs-akhan · 2017-12-20T23:08:15Z

Yaaaaay.. Cannot express how glad I am.. :)
Looking for many more PRs in future..
Thank you for all your precious time and efforts @nicolo-ribaudo & @existentialism

nicolo-ribaudo · 2017-12-20T23:10:45Z

@gs-akhan This just need another approval, than can be merged 🙂

Azharuddin added 2 commits December 21, 2017 02:32

Better error messages when Babel fails to parse import = and export =…

5db4e50

… syntax from typescript when using babel-plugin-transform-typescript

Fixing Test cases

48cde24

Ran make fix and broken looong sentence into smaller

e9d9d1c

nicolo-ribaudo reviewed Dec 20, 2017

View reviewed changes

existentialism added area: typescript PR: Polish 💅 A type of pull request used for our changelog categories labels Dec 20, 2017

Slight changes to Messages after review with Nicolo & existentialism

6ddc2b0

nicolo-ribaudo reviewed Dec 20, 2017

View reviewed changes

Removed trailing space

262f33e

nicolo-ribaudo approved these changes Dec 20, 2017

View reviewed changes

existentialism approved these changes Dec 20, 2017

View reviewed changes

yavorsky approved these changes Dec 20, 2017

View reviewed changes

yavorsky merged commit 2190e10 into babel:master Dec 21, 2017

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better error messages when Babel fails to parse import = and export =… #7079

Better error messages when Babel fails to parse import = and export =… #7079

gs-akhan commented Dec 20, 2017 •

edited

Loading

babel-bot commented Dec 20, 2017 •

edited

Loading

nicolo-ribaudo commented Dec 20, 2017

gs-akhan commented Dec 20, 2017 via email

nicolo-ribaudo commented Dec 20, 2017

gs-akhan commented Dec 20, 2017 via email

nicolo-ribaudo Dec 20, 2017

gs-akhan Dec 20, 2017

nicolo-ribaudo Dec 20, 2017

nicolo-ribaudo Dec 20, 2017

gs-akhan Dec 20, 2017

existentialism Dec 20, 2017

gs-akhan Dec 20, 2017

nicolo-ribaudo Dec 20, 2017 •

edited

Loading

gs-akhan Dec 20, 2017

nicolo-ribaudo Dec 20, 2017 •

edited

Loading

gs-akhan Dec 20, 2017

nicolo-ribaudo Dec 20, 2017 •

edited

Loading

gs-akhan Dec 20, 2017

gs-akhan Dec 20, 2017

nicolo-ribaudo Dec 20, 2017

gs-akhan Dec 20, 2017

nicolo-ribaudo left a comment

gs-akhan commented Dec 20, 2017

nicolo-ribaudo commented Dec 20, 2017

Better error messages when Babel fails to parse import = and export =… #7079

Better error messages when Babel fails to parse import = and export =… #7079

Conversation

gs-akhan commented Dec 20, 2017 • edited Loading

babel-bot commented Dec 20, 2017 • edited Loading

nicolo-ribaudo commented Dec 20, 2017

gs-akhan commented Dec 20, 2017 via email

nicolo-ribaudo commented Dec 20, 2017

gs-akhan commented Dec 20, 2017 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolo-ribaudo Dec 20, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolo-ribaudo Dec 20, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolo-ribaudo Dec 20, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

gs-akhan commented Dec 20, 2017

nicolo-ribaudo commented Dec 20, 2017

gs-akhan commented Dec 20, 2017 •

edited

Loading

babel-bot commented Dec 20, 2017 •

edited

Loading

nicolo-ribaudo Dec 20, 2017 •

edited

Loading

nicolo-ribaudo Dec 20, 2017 •

edited

Loading

nicolo-ribaudo Dec 20, 2017 •

edited

Loading