Fix incorrect value of _cache in _wrapNativeSuper #7570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boolean expressions returns false in environments where Map is missing. This change explicitly sets _cache to undefined in such cases, to ensure the cache methods will be ignored.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7249/ |
1 similar comment
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7249/ |
existentialism
added
the
PR: Bug Fix 🐛
existentialism
approved these changes
Mar 14, 2018
This was referenced Mar 16, 2018
Closed
Closed
aminmarashi
pushed a commit
to aminmarashi/babel
that referenced
this pull request
Mar 17, 2018
The boolean expressions returns false in environments where Map is missing. This change explicitly sets _cache to undefined in such cases, to ensure the cache methods will be ignored.
mAAdhaTTah
added a commit
to valtech-nyc/babel
that referenced
this pull request
Mar 18, 2018
* master: (131 commits) v7.0.0-beta.42 Use strict namespace behavior for mjs files. (babel#7545) Remove outdated spec deviation note [skip ci] (babel#7571) Ensure that the backward-compat logic for plugin-utils copies over the version API properly. (babel#7580) Rename actual/expected test files to input/output (babel#7578) Use helper-module-import inside entry plugin too Use helper-module-imports instead of custom import (babel#7457) Fix "Module build failed: Error: Cannot find module '@babel/types'" (babel#7575) Wrap wrapNativeSuper helpers in redefining functions for better tree-shakeability (babel#7188) Favour extends helper over objectWithoutProperties when whole object gets copied anyway (babel#7390) Fix incorrect value of _cache in _wrapNativeSuper (babel#7570) [transform-classes] Fix typo in _wrapNativeSuper helper [typeof-symbol] Guard against undefined built-in globals update to beta.41 (babel#7568) v7.0.0-beta.41 Fix import of type ConfigItem (babel#7561) Run node 9 on circleci and remove from travis (babel#7560) docs: [skip ci] fix proposal link text update preset-env after build-data (babel#7543) Re-add TEST_ONLY and use Jest's -t for TEST_GREP. (babel#7556) ...
mAAdhaTTah
added a commit
to valtech-nyc/babel
that referenced
this pull request
Mar 18, 2018
…ature/pipe-await * 'master' of https://github.com/valtech-nyc/babel: (131 commits) v7.0.0-beta.42 Use strict namespace behavior for mjs files. (babel#7545) Remove outdated spec deviation note [skip ci] (babel#7571) Ensure that the backward-compat logic for plugin-utils copies over the version API properly. (babel#7580) Rename actual/expected test files to input/output (babel#7578) Use helper-module-import inside entry plugin too Use helper-module-imports instead of custom import (babel#7457) Fix "Module build failed: Error: Cannot find module '@babel/types'" (babel#7575) Wrap wrapNativeSuper helpers in redefining functions for better tree-shakeability (babel#7188) Favour extends helper over objectWithoutProperties when whole object gets copied anyway (babel#7390) Fix incorrect value of _cache in _wrapNativeSuper (babel#7570) [transform-classes] Fix typo in _wrapNativeSuper helper [typeof-symbol] Guard against undefined built-in globals update to beta.41 (babel#7568) v7.0.0-beta.41 Fix import of type ConfigItem (babel#7561) Run node 9 on circleci and remove from travis (babel#7560) docs: [skip ci] fix proposal link text update preset-env after build-data (babel#7543) Re-add TEST_ONLY and use Jest's -t for TEST_GREP. (babel#7556) ...
mAAdhaTTah
added a commit
to valtech-nyc/babel
that referenced
this pull request
Mar 21, 2018
* master: (140 commits) Update to beta.42 (babel#7609) Disable flow on transformClass, fix preset-env errors (babel#7605) Logical Assignment: ensure computed key isn't recomputed (babel#7604) Remove obsolete max-len eslint rule and reformat some stuff to fit (babel#7602) Centralize Babel's own compilation config to make it easier to follow. (babel#7599) Run prettier to format all JSON. Tweak es2015-related plugin order in preset-env (babel#7586) Refactored quirky inheritance in babel-plugin-transform-classes (babel#7444) Add RegExp support to include/exclude preset-env options (babel#7242) v7.0.0-beta.42 Use strict namespace behavior for mjs files. (babel#7545) Remove outdated spec deviation note [skip ci] (babel#7571) Ensure that the backward-compat logic for plugin-utils copies over the version API properly. (babel#7580) Rename actual/expected test files to input/output (babel#7578) Use helper-module-import inside entry plugin too Use helper-module-imports instead of custom import (babel#7457) Fix "Module build failed: Error: Cannot find module '@babel/types'" (babel#7575) Wrap wrapNativeSuper helpers in redefining functions for better tree-shakeability (babel#7188) Favour extends helper over objectWithoutProperties when whole object gets copied anyway (babel#7390) Fix incorrect value of _cache in _wrapNativeSuper (babel#7570) ...
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when inspecting the build output of a project. The fix is small, so I'm submitting it as a PR directly instead of opening an issue. Hope that's alright.
The boolean expression in the definition of the
_cachevariable in the_wrapNativeSuperhelper returnsfalsein environments where Map is missing. This would make the latertypeofcheck pass, since it only checks if the type is actuallyundefined.This change explicitly sets
_cachetoundefinedif Map is missing, to ensure the cache methods will be ignored.