Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default highlightCode:true for the parser highlighting. #8546

Merged
merged 1 commit into from
Aug 26, 2018
Merged

Default highlightCode:true for the parser highlighting. #8546

merged 1 commit into from
Aug 26, 2018

Conversation

loganfsmyth
Copy link
Member

Q                       A
Fixed Issues? Fixes #8543
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Looks like I regressed this in #6783

@loganfsmyth loganfsmyth added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: core labels Aug 26, 2018
@loganfsmyth loganfsmyth mentioned this pull request Aug 26, 2018
Closed
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8936/

@loganfsmyth loganfsmyth merged commit e0ee057 into babel:master Aug 26, 2018
@loganfsmyth loganfsmyth deleted the default-highlight branch August 26, 2018 20:23
@marcofugaro marcofugaro mentioned this pull request Sep 25, 2018
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: core PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the option "highlightCode" should default to true
3 participants
@loganfsmyth @babel-bot @nicolo-ribaudo