Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use babel-check-duplicated-nodes #8768

Merged

Conversation

nicolo-ribaudo
Copy link
Member

The code that I removed in this PR was extracted by @Andarist so that it can aldo be used by regenerator. babel-check-duplicated-nodes contains exactly the same code.

@nicolo-ribaudo nicolo-ribaudo added PR: Internal 🏠 A type of pull request used for our changelog categories PR: New Dependency labels Sep 25, 2018
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9172/

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@Andarist
Copy link
Member

Andarist commented Oct 5, 2018

Maybe we should move babel-check-duplicated-nodes to babel org or even to the monorepo? The reason why I have extracted it was that at the time it has allowed duplicated nodes in regenerator output and I was fixing exactly this - duplicated nodes in regenerator, so I have needed a version without regenerator-specific lines.

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories PR: New Dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants