Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error #146

Merged
merged 6 commits into from
Jul 24, 2018
Merged

Improve error #146

merged 6 commits into from
Jul 24, 2018

Conversation

stefanpenner
Copy link
Member

No description provided.

@stefanpenner stefanpenner requested a review from mikrostew July 19, 2018 19:55
@Turbo87
Copy link
Contributor

Turbo87 commented Jul 19, 2018

asdf?

@rwjblue
Copy link
Member

rwjblue commented Jul 19, 2018

Looks like CI failures are due to incompatibilities in how (function() {}).toString() works on various node versions.

       {
         "errors": [
           "name: unknown, located at: unknown"
      -    "name: unknown, located at: unknown, src: function () {}"
      +    "name: unknown, located at: unknown, src: function() {}"
         ]
         "isParallelizable": false
       }

@stefanpenner stefanpenner force-pushed the improve-error branch 2 times, most recently from 397e096 to cf7b346 Compare July 19, 2018 21:18
@stefanpenner
Copy link
Member Author

I'm currently debugging some of these issues locally, and updating this PR as I find ways to make it more actionable

@stefanpenner
Copy link
Member Author

Not perfect, but pretty actionable so far:

screen shot 2018-07-19 at 2 39 06 pm

@stefanpenner stefanpenner force-pushed the improve-error branch 2 times, most recently from e771d74 to 9b7d1f1 Compare July 19, 2018 23:23
mikrostew
mikrostew approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@mikrostew mikrostew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

index.js Outdated

if ((this.throwUnlessParallelizable || process.env.THROW_UNLESS_PARALLELIZABLE) && isParallelizable === false) {
throw new Error(this.toString() +
' was configured to `throwUnlessParallelizable` and was unable to parallelize an plugin. \nplugins:\n' + joinCount(errors) + '\nPlease see: https://github.com/babel/broccoli-babel-transpiler#parallel-transpilation for more details');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "parallelize a plugin"

@stefanpenner stefanpenner mentioned this pull request Jul 24, 2018
Merged
2 tasks
@stefanpenner stefanpenner mentioned this pull request Jul 24, 2018
Open
@stefanpenner
Copy link
Member Author

stefanpenner commented Jul 24, 2018 •
edited
Loading

- [ ] fix: a plugin of the form: [serializable, nonSerializable] will incorrectly display serializable as the problem, not nonSerializable -> #147

@stefanpenner stefanpenner merged commit eb0e007 into master Jul 24, 2018
@stefanpenner stefanpenner deleted the improve-error branch July 24, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

@mikrostew mikrostew mikrostew approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefanpenner @Turbo87 @rwjblue @mikrostew