Pass through original code if Babel has ignored #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Babel v7 when a file has been ignored "transform" returns null (in Babel v6 the original code was returned). In this case karma-babel-preprocessor errors as it tries to access the property "code" on the null value. See https://babeljs.io/docs/en/v7-migration-api "Calls to babel.transform or any other transform function may return null if the file matched an ignore pattern or failed to match an only pattern"
|
Thanks a lot for the fix! Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Babel v7 when a file has been ignored "transform" returns null (in Babel v6 the original code was returned).
In this case karma-babel-preprocessor errors as it tries to access the property "code" on the null value.
See https://babeljs.io/docs/en/v7-migration-api
"Calls to babel.transform or any other transform function may return null if the file matched an ignore pattern or failed to match an only pattern"