Bail for binary 'in' expressions - fix #691 (#705)

* Bail for binary 'in' expressions - fix #691 * Remove unnecessary code
babel · Oct 4, 2017 · 3e9821c · 3e9821c
1 parent b729a41
commit 3e9821c
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 0 deletions.
diff --git a/packages/babel-plugin-minify-dead-code-elimination/__tests__/dead-code-elimination-test.js b/packages/babel-plugin-minify-dead-code-elimination/__tests__/dead-code-elimination-test.js
@@ -2503,4 +2503,17 @@ describe("dce-plugin", () => {
       plugins: [[deadcode, { tdz: true }]]
     }
   );
+
+  thePlugin(
+    "should bail for binary `in` expressions - fix #691",
+    `
+      function foo(props) {
+        let bar = "width" in props;
+        delete props.width;
+        if (bar) {
+          console.log("foo");
+        }
+      }
+    `
+  );
 });
diff --git a/packages/babel-plugin-minify-dead-code-elimination/src/index.js b/packages/babel-plugin-minify-dead-code-elimination/src/index.js
@@ -391,13 +391,43 @@ module.exports = ({ types: t, traverse }) => {
                 t.isFunction(n) ||
                 t.isObjectExpression(n) ||
                 t.isArrayExpression(n);
+
               const isReplacementObj =
                 isObj(replacement) || some(replacement, isObj);
 
               if (!sharesRoot || (isReplacementObj && mayLoop)) {
                 continue;
               }
 
+              // check if it's safe to replace
+              // To solve https://github.com/babel/minify/issues/691
+              // Here we bail for property checks using the "in" operator
+              // This is because - `in` is a side-effect-free operation but the property
+              // could be deleted between the replacementPath and referencePath
+              // It is expensive to compute the delete operation and we bail for
+              // all the binary "in" operations
+              let inExpression = replacementPath.isBinaryExpression({
+                operator: "in"
+              });
+
+              if (!inExpression) {
+                replacementPath.traverse({
+                  Function(path) {
+                    path.skip();
+                  },
+                  BinaryExpression(path) {
+                    if (path.node.operator === "in") {
+                      inExpression = true;
+                      path.stop();
+                    }
+                  }
+                });
+              }
+
+              if (inExpression) {
+                continue;
+              }
+
               const replaced = replace(binding.referencePaths[0], {
                 binding,
                 scope,