Fix folding Array literals (close #608) (close #609)

babel · Jun 30, 2017 · ca943e7 · ca943e7
1 parent fd79492
commit ca943e7
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/babel-plugin-minify-constant-folding/__tests__/constant-folding-test.js b/packages/babel-plugin-minify-constant-folding/__tests__/constant-folding-test.js
@@ -226,4 +226,16 @@ describe("constant-folding-plugin", () => {
     ({}).toString;
   `
   );
+
+  thePlugin(
+    "should bail for spread element in array",
+    `
+      function foo() {
+        return [...iter].length;
+      }
+      function bar() {
+        return [...iter][0];
+      }
+    `
+  );
 });
diff --git a/packages/babel-plugin-minify-constant-folding/src/replacements.js b/packages/babel-plugin-minify-constant-folding/src/replacements.js
@@ -23,9 +23,15 @@ module.exports = ({ types: t }) => {
     ArrayExpression: {
       members: {
         length() {
+          if (this.elements.some(el => t.isSpreadElement(el))) {
+            return;
+          }
           return t.numericLiteral(this.elements.length);
         },
         [FALLBACK_HANDLER](i) {
+          if (this.elements.some(el => t.isSpreadElement(el))) {
+            return;
+          }
           if (typeof i === "number" || i.match(/^\d+$/)) {
             return this.elements[i] || undef;
           }