Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set hard dependency on babel.version #70

Closed
boopathi opened this issue Jul 31, 2016 · 1 comment
Closed

Set hard dependency on babel.version #70

boopathi opened this issue Jul 31, 2016 · 1 comment

Comments

@boopathi
Copy link
Member

The preset or cli or node api when used with previous versions of babel, due to the rename bugs and evaluate bugs, we will be introducing bugs in user code that will be hard to grok that it is a bug with babel. We need to either fix this somehow for mangle and evaluate in the minifier or set hard dependency that it bails out for older versions of babel.
@boopathi boopathi changed the title Set hard Set hard dependency on babel.version Jul 31, 2016
@boopathi
Copy link
Member Author

There was a nice explanation from @loganfsmyth on slack. -
https://github.com/babel/notes/pull/1/files#diff-df831bd7dde5a9b87de74fe01f0acf3dR88

boopathi added a commit that referenced this issue Aug 27, 2016
@boopathi
Throw upgrade error when babel version is less than 6.14.0
ea238ef 
+ (Close #70)
+ related #114
@boopathi boopathi mentioned this issue Aug 27, 2016
Merged
kangax pushed a commit that referenced this issue Aug 29, 2016
@boopathi @kangax
Throw upgrade error when babel version is less than 6.14.0 (#116)
2da1cc5 
* Throw upgrade error when babel version is less than 6.14.0

+ (Close #70)
+ related #114

* Update error message

* Simplify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boopathi