Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Simplify Tests #129

Closed
wants to merge 4 commits into from
Closed

[WIP] Simplify Tests #129

wants to merge 4 commits into from

Conversation

boopathi
Copy link
Member

#76

just wrote some codemod - and hand edited some edge cases.
https://gist.github.com/boopathi/d979e5266df861052783acf9d3e61d22

Take a look before we apply to other packages

@boopathi boopathi added the Tag: Internal Pull Request changing project internals - code that is NOT published label Aug 31, 2016
@kangax
Copy link
Member

kangax commented Aug 31, 2016

My concern is that source and destination strings are in different places so it might be annoying to look back and forth.

@hzoo what do ya think

@boopathi
Copy link
Member Author

Yeah, I felt that too. So I thought we could do

expect({
  source,
  result: transform(source)
}).toMatchSnapshot()

@hzoo
Copy link
Member

hzoo commented Sep 1, 2016

A good point - being able to see the source/expected easily is useful

@kangax
Copy link
Member

kangax commented Sep 2, 2016

Not sure if snapshot is the most appropriate approach here unless we can have input/output specified together.

@hzoo
Copy link
Member

hzoo commented Sep 2, 2016

Maybe we can leave this here and revisit.

Implementing what I wrote originally is easier and just reduces boilerplate

@boopathi boopathi closed this Apr 18, 2017
@boopathi boopathi deleted the test-suite-0 branch April 18, 2017 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: Internal Pull Request changing project internals - code that is NOT published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants