Fix DCE tests with labels in separate namespace #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
reviewed
Oct 26, 2016
|
|
||
| function getLabel(name, _path) { | ||
| let label, path = _path; | ||
| while (!path.isProgram()) { |
There was a problem hiding this comment.
you can use path.find/path.findParent here right?
There was a problem hiding this comment.
yes... will change it
There was a problem hiding this comment.
hmm.. But I want to return the label instead of the parent.
hzoo
added
bug
kangax
pushed a commit
that referenced
this pull request
Nov 2, 2016
* Fix DCE tests with labels in separate namespace * Convert to do..while loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work on babel version <6.18.0 and >6.18.0 ...