Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont lift declarations when not intialized (fix #309) #314

Merged
merged 1 commit into from
Dec 1, 2016
Merged

dont lift declarations when not intialized (fix #309) #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...gin-transform-merge-sibling-variables/__tests__/transform-merge-sibling-variables-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,16 @@ describe("transform-merge-sibling-variables-plugin", () => {
expect(transform(source)).toBe(source);
});

it("dont lift when the declarations are not initialized", () => {
const source = unpad(`
for (var i = 0;;) {
var i;
}
`);

expect(transform(source)).toBe(source);
});

it("dont lift when there are multiple declarations", () => {
const source = unpad(`
for (var i = 0; i < 0; i++) {
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-plugin-transform-merge-sibling-variables/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module.exports = function({ types: t }) {

let firstNode = body[0].node.declarations[0];

if (!t.isIdentifier(firstNode.id)) {
if (!t.isIdentifier(firstNode.id) || !firstNode.init) {
return;
}

Expand Down