Refactor the test suite #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies tests that check that a certain code snippet gets transformed to another snippet.
utils/test-transform.js
Outdated
| } | ||
| }); | ||
| }; | ||
| thePlugin.skip = name => it.skip(name); |
There was a problem hiding this comment.
you would also need to support only if we would like to run a single test during dev..
|
The cleanup looks good overall.. Thanks a lot 👍 |
boopathi
added
the
Tag: Internal
|
This looks great! I thought of moving it to fixtures based testing - each test case in 2 files - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test helper that creates a testing function, which is usually called
thePlugin, which streamlines testing transforms. I’ve also gone through and edited some of the test names for clarity.