Fix folding array literals - bail on spread element #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
boopathi
commented
Sep 25, 2017
boopathi
commented
- Fixes Array spread with function call broken in 0.2.0 #695
- Fixes Some of the plugin in this preset delete array reverse call #628
- Related Fix folding Array literals (close #608) (close #609) #610
j-f1
reviewed
Sep 25, 2017
| @@ -51,7 +58,7 @@ module.exports = ({ types: t }) => { | |||
| return evaled.value; | |||
| }) | |||
| .join(sep.value); | |||
| return bad ? undefined : t.stringLiteral(str); | |||
| return bad ? void 0 : t.stringLiteral(str); | |||
There was a problem hiding this comment.
Why does this use void 0 instead of undefined?
There was a problem hiding this comment.
we use void 0 everywhere in the project. Just sticking to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.