Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix Regex's containing (\0) #733

Merged
merged 2 commits into from
Nov 27, 2017
Merged

Bugfix Regex's containing (\0) #733

merged 2 commits into from
Nov 27, 2017

Conversation

jogibear9988
Copy link
Contributor

fixes #732

@jogibear9988 jogibear9988 mentioned this pull request Nov 19, 2017
Closed
@jogibear9988
Copy link
Contributor Author

Don't know why one test fails, I can't run them localy...

@jogibear9988
Copy link
Contributor Author

@boopathi can you help me with the failing test?

@j-f1
Copy link
Contributor

j-f1 commented Nov 22, 2017

Have you considered instead optimizing the regex like it is done currently, then running regexSource.replace(/\0/g, '\\0')?

@j-f1
Copy link
Contributor

j-f1 commented Nov 22, 2017

Try running yarn install --force, then yarn run fix to fix the test failures.

@jogibear9988
Copy link
Contributor Author

i‘ll try! thx!

@jogibear9988
Copy link
Contributor Author

I thought about doing this, but I’ve not realy thought about what this module is doing, I only wanted to find what breaks.

@jogibear9988 jogibear9988 force-pushed the patch-1 branch 4 times, most recently from 9c1cf88 to bb91fc7 Compare November 23, 2017 13:26
@jogibear9988
Copy link
Contributor Author

@j-f1 can you review?

j-f1
j-f1 approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jogibear9988
Copy link
Contributor Author

@boopathi failing tests now fixed, and unit test for functionality created!

This was referenced Nov 24, 2017
Closed
Closed
@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label Nov 27, 2017
@boopathi boopathi merged commit f7ff978 into babel:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-f1 j-f1 j-f1 approved these changes

@boopathi boopathi Awaiting requested review from boopathi boopathi is a code owner

Assignees
No one assigned
Labels
Tag: Bug Fix Pull Request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minify breaks jquery -> replaces \0 with NUL (Ascii)
3 participants
@jogibear9988 @j-f1 @boopathi