Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update outdated react url #817

Merged
merged 3 commits into from
Apr 23, 2018
Merged

fix: update outdated react url #817

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb7d1cc
Remove outdated react url
ganes1410 Apr 5, 2018
5be560b
Update react url
ganes1410 Apr 15, 2018
86cdb13
Update outdated url
ganes1410 Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const butternut = require("butternut");

const ASSETS_DIR = path.join(__dirname, "benchmark_cache");
const DEFAULT_ASSETS = {
"react.js": "https://unpkg.com/react/dist/react.js", // 120 kb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would like to keep react as a dep here since we use it for smoke tests.

So please update with the new URL instead of removing it. You can find the relevant code here https://unpkg.com/react@16.3.1/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vigneshshanmugam should i update it with react.development.js or react.production.js ??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use development.js

"react.js": "https://unpkg.com/react@16.3.1/umd/react.development.js", //56kb
"vue.js": "https://unpkg.com/vue/dist/vue.js", // 230 kb
"lodash.js": "https://unpkg.com/lodash/lodash.js", // 500kb
"three.js": "https://unpkg.com/three/build/three.js" // 1000kb
Expand Down