fix: account for different scopes during path evaluation #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boopathi
reviewed
May 3, 2018
| return { shouldDeopt: true }; | ||
| } | ||
|
|
||
| let blockParent = binding.path.scope.getBlockParent().path; |
There was a problem hiding this comment.
Block parent cannot be null, it returns Program path.
boopathi
reviewed
May 3, 2018
|
|
||
| if (node.kind !== "var") { | ||
| return; | ||
| } |
There was a problem hiding this comment.
why is this changed? Let's stick to .isType( params )
There was a problem hiding this comment.
Checking for isVariableDeclaration inside variableDeclaration feels weird. So changed it.
Also it checks first for type and kind.
There was a problem hiding this comment.
isVariableDeclaration has kind ... So let's change it back.
vigneshshanmugam
force-pushed
the
recalc-scope
branch
from
ce2fef2 to
537fb23
Compare
vigneshshanmugam
force-pushed
the
recalc-scope
branch
from
537fb23 to
b6d9675
Compare
boopathi
approved these changes
May 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix "if" condition is incorrectly omitted after minify #810
fix if statement wrongly removed when var declaration inside conditional block #574 properly