Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicer loading state for new REPL #1325

Closed
Daniel15 opened this issue Aug 16, 2017 · 3 comments
Closed

Nicer loading state for new REPL #1325

Daniel15 opened this issue Aug 16, 2017 · 3 comments
Assignees
@bvaughn
Labels
design repl
Milestone
New REPL

Comments

@Daniel15
Copy link
Member

While the JS is loading, the new REPL just shows some plain "Loading" text at the top left. Let's add a slightly nicer loading state - At least bigger text and centered, or something like that. I'm not a designer 😛
@Daniel15 Daniel15 added this to the New REPL milestone Aug 16, 2017
@bvaughn bvaughn self-assigned this Aug 17, 2017
@bvaughn
Copy link
Contributor

bvaughn commented Aug 18, 2017

I think we can probably use a similar UI treatment as was added in #1318.

loading

@Daniel15
Copy link
Member Author

Daniel15 commented Aug 18, 2017 •
edited
Loading

Good idea. We should be able to update that loading state to use plain CSS (and maybe a bit of JS) so it can be used as a loading indicator for the entire REPL, before the JS has loaded.

@bvaughn
Copy link
Contributor

bvaughn commented Aug 18, 2017

Agreed!

@bvaughn bvaughn mentioned this issue Aug 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvaughn bvaughn

Labels
design repl
Projects
None yet
Milestone
New REPL
Development

No branches or pull requests
3 participants
@bvaughn @Daniel15 @xtuc