Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom loading animation/page for REPL #1340

Merged
merged 2 commits into from
Aug 20, 2017
Merged

Custom loading animation/page for REPL #1340

merged 2 commits into from
Aug 20, 2017

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Aug 20, 2017

Resolves #1325

screen shot 2017-08-19 at 10 49 50 pm

screen shot 2017-08-19 at 10 50 05 pm

@bvaughn bvaughn requested a review from Daniel15 August 20, 2017 05:52
Daniel15
Daniel15 reviewed Aug 20, 2017
View reviewed changes
repl2.html Outdated
</div>

<style type="text/css">
@keyframes repl-loading-animation {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this in _sass/pages/_repl.scss? We've already loaded the CSS by this point, as it's in the <head>. May as well put this in there 😃

@babel-bot
Copy link
Contributor

babel-bot commented Aug 20, 2017 •
edited
Loading

Deploy preview ready!

Built with commit f06e61d

https://deploy-preview-1340--babel.netlify.com

@Daniel15
Copy link
Member

I think this also means that you can remove all the styling from js/repl/PresetLoadingAnimation.js and just use the CSS classes, right?

@bvaughn
Copy link
Contributor Author

bvaughn commented Aug 20, 2017

Oh yeah, _sass/pages/_repl.scss ... Duh lol

I'll be less stupid in the morning 😁 will fix it up then

@bvaughn
Copy link
Contributor Author

bvaughn commented Aug 20, 2017

I think this also means that you can remove all the styling from js/repl/PresetLoadingAnimation.js and just use the CSS classes, right?

We could but I'd prefer to keep the 2 separate. Sharing within Glamor's styles would be okay since it would require explicit imports but I don't dig the idea of a hidden dep between the Jekyll/SASS styles and the Glamor ones.

@Daniel15
Copy link
Member

Tested on https://deploy-preview-1340--babel.netlify.com/repl2/, looks great!

@Daniel15 Daniel15 merged commit 44af15c into master Aug 20, 2017
@Daniel15 Daniel15 deleted the loading-animation branch August 20, 2017 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel15 Daniel15 Daniel15 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvaughn @babel-bot @Daniel15