-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update babel.github.io babili plugin docs #1029
Update babel.github.io babili plugin docs #1029
Conversation
package: babel-plugin-minify-simplify | ||
--- | ||
|
||
{% include package_readme.html from="babili" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this happens, the README seems good: https://github.com/babel/babili/blob/master/packages/babel-plugin-minify-simplify/README.md
/cc @existentialism
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add an extra line between the text and the code block, since markdownify behaves differently than GH flavored markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make the changes now. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @existentialism Is this where the actual documentation is, not on this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xtuc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xtuc pushed a quick fix: babel/minify#320
--- | ||
layout: docs | ||
title: Regexp constructors transform | ||
description: This plugin allows Babel to transform boolean literals into !0 for true and !1 for false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should be This changes RegExp constructors into literals if the RegExp arguments are strings.
4119e6a
to
10ecf11
Compare
@xtuc - Have fixed the description above and squashed into the original commit ^ Thanks |
Great, thanks for your work. LGTM 👍 |
nice stuff @geordidearns! thanks for contributing! |
Hey @hzoo - Ready for a review - Updated the babili plugin documentation on the github pages website to eliminate duplication of documentation. Also added plugin files which weren't there.
Let me know if you need anything re-named, or changed.
Thanks,
Geordi