Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar overlap console output #1288

Closed
wants to merge 1 commit into from

Conversation

artemgurzhii
Copy link

When compiled code length does not fit into the screen it adds a scrollbar, which can overlap console output. Visit Babel repl for more info.

@xtuc
Copy link
Member

xtuc commented Aug 3, 2017

Thanks for PR. Could you send a screen capture of this issue?

It's fine for me:
screenshot from 2017-08-03 13-04-22

@artemgurzhii
Copy link
Author

@xtuc image

@existentialism
Copy link
Member

existentialism commented Aug 6, 2017

@artemgurzhii it's still weird if debug is enabled in your example:

image

Short fix is to bump z-index, the more involved fix is to use flexbox in babel-repl-right-panel to deal with the console output being variable height.

(Sorry for delay in review)

@artemgurzhii
Copy link
Author

@existentialism Noticed that my fix only works for one line errors. How does this look for you?

P.S. I has tried to increment z-index property and this doesn't look for me as a good solution because it overlaps output section scrollbar.

@xtuc
Copy link
Member

xtuc commented Aug 14, 2017

Will be fixed in #1297

@artemgurzhii
Copy link
Author

Fixed in 1297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants