-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update download-readmes.js -> Babylon #1496
Conversation
Babylon has been moved into the main Babel mono-repo. Change download uri to /babel/babel/master/packages/babylon/README.md
Deploy preview ready! Built with commit b3e134d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@yavorsky Not at all. |
Hmm.. I just remembered why we haven't done that before... Look at the babel-preset-env docs uri: https://github.com/QC-L/babeljs.io/blob/b3e134dc6fb068ae6be04236afe1d7a1b9718f9d/scripts/download-readmes.js#L44 So we need to be consistent and update preset-env also since we've moved it to the monorepo like Babylon, or use Babylon's 6.x branch because preset-env refers to 1.x. Sorry for the initial confusion. |
@yavorsky I see. Thank you. Look forward to the release of Babel 7. |
@QC-L You can update this PR with a branch name change to |
Nothing, no hurry. Wait for you to update. |
Yeah with #1485 - we should have versioned docs so it won't be as confusing |
Can close now since we have the new docs |
Babylon has been moved into the main Babel mono-repo.
Change download uri to /babel/babel/master/packages/babylon/README.md.