Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download-readmes.js -> Babylon #1496

Closed
wants to merge 1 commit into from
Closed

Update download-readmes.js -> Babylon #1496

wants to merge 1 commit into from

Conversation

QC-L
Copy link
Contributor

@QC-L QC-L commented Dec 28, 2017

Babylon has been moved into the main Babel mono-repo.
Change download uri to /babel/babel/master/packages/babylon/README.md.

Babylon has been moved into the main Babel mono-repo.
Change download uri to /babel/babel/master/packages/babylon/README.md
@babel-bot
Copy link
Contributor

Deploy preview ready!

Built with commit b3e134d

https://deploy-preview-1496--babel.netlify.com

Copy link
Member

@yavorsky yavorsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@QC-L
Copy link
Contributor Author

QC-L commented Dec 28, 2017

@yavorsky Not at all.

@yavorsky
Copy link
Member

Hmm.. I just remembered why we haven't done that before...
Actually, we haven't released 7 yet, so the website doesn't refer to any 7 stuff.

Look at the babel-preset-env docs uri: https://github.com/QC-L/babeljs.io/blob/b3e134dc6fb068ae6be04236afe1d7a1b9718f9d/scripts/download-readmes.js#L44

So we need to be consistent and update preset-env also since we've moved it to the monorepo like Babylon, or use Babylon's 6.x branch because preset-env refers to 1.x.
I'd prefer the 2 option unless Babel 7 released.

Sorry for the initial confusion.

@QC-L
Copy link
Contributor Author

QC-L commented Dec 28, 2017

@yavorsky I see. Thank you. Look forward to the release of Babel 7.

@yavorsky
Copy link
Member

@QC-L You can update this PR with a branch name change to 6.x. 🙂

@QC-L
Copy link
Contributor Author

QC-L commented Dec 28, 2017

Nothing, no hurry. Wait for you to update.

@hzoo
Copy link
Member

hzoo commented Jan 7, 2018

Yeah with #1485 - we should have versioned docs so it won't be as confusing

@hzoo hzoo mentioned this pull request Jan 24, 2018
@hzoo
Copy link
Member

hzoo commented Feb 23, 2018

Can close now since we have the new docs

@hzoo hzoo closed this Feb 23, 2018
@QC-L QC-L deleted the patch-2 branch February 27, 2018 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants