Fix Datapart functions to be Timezone Invariant #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 9, 2024 07:21
Signed-off-by: Nirmit Shah <nirmisha@amazon.com>
added 2 commits
December 11, 2024 05:40
Signed-off-by: Nirmit Shah <nirmisha@amazon.com>
Pull Request Test Coverage Report for Build 12292019918Details
💛 - Coveralls |
Anikait143
reviewed
Dec 11, 2024
added 2 commits
December 12, 2024 07:45
Signed-off-by: Nirmit Shah <nirmisha@amazon.com>
sumitj824
approved these changes
Dec 12, 2024
Anikait143
approved these changes
Dec 12, 2024
jsudrik
merged commit 5a092d3
into
babelfish-for-postgresql:BABEL_5_X_DEV
44 checks passed
This was referenced Dec 13, 2024
jsudrik
pushed a commit
that referenced
this pull request
Dec 16, 2024
We were incorrectly passing timezone to timestamp2tm function which would cause the datepart functions to be timezone dependent , If we pass tzp by reference to timestamp2tm function, then internally localtime converts the given original timestamp value to date and time values adding timezone offset taking GMT as a reference timezone. However, if NULL is passed instead then we keep the original timestamp intact and that's what actually PG does. Cherry-pick #3226 Issues Resolved BABEL-5453 Signed-off-by: Nirmit Shah nirmisha@amazon.com
jsudrik
pushed a commit
that referenced
this pull request
Dec 17, 2024
We were incorrectly passing timezone to timestamp2tm function which would cause the datepart functions to be timezone dependent , If we pass tzp by reference to timestamp2tm function, then internally localtime converts the given original timestamp value to date and time values adding timezone offset taking GMT as a reference timezone. However, if NULL is passed instead then we keep the original timestamp intact and that's what actually PG does. Cherry pick #3226 Issues Resolved BABEL-5453 Signed-off-by: Nirmit Shah nirmisha@amazon.com
timchang514
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Dec 17, 2024
…esql#3253) We were incorrectly passing timezone to timestamp2tm function which would cause the datepart functions to be timezone dependent , If we pass tzp by reference to timestamp2tm function, then internally localtime converts the given original timestamp value to date and time values adding timezone offset taking GMT as a reference timezone. However, if NULL is passed instead then we keep the original timestamp intact and that's what actually PG does. Cherry pick babelfish-for-postgresql#3226 Issues Resolved BABEL-5453 Signed-off-by: Nirmit Shah nirmisha@amazon.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were incorrectly passing timezone to
timestamp2tmfunction which would cause the datepart functions to be timezone dependent , If we pass tzp by reference to timestamp2tm function, then internally localtime converts the given original timestamp value to date and time values adding timezone offset taking GMT as a reference timezone. However, if NULL is passed instead then we keep the original timestamp intact and that's what actually PG does.Issues Resolved
BABEL-5453
Signed-off-by: Nirmit Shah nirmisha@amazon.com
Test Scenarios Covered
Use case based - YES
Boundary conditions - YES
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.