Allow string functions to be called with arguments of datatypes that were supported earlier #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 12, 2024 20:00
…were supported earlier (babelfish-for-postgresql#3192) While fixing issue in string functions for input containing multibyte characters, we blocked string functions called with some datatypes to be more compliance with TSQL, which were supported earlier by using underlying PostgreSQL string functions. This PR include changes to allow all string functions to be called on all the datatypes that were support earlier. Following are the string functions which faced this issue and will be fixed with this PR:- CONCAT, CONCAT_WS STRING_AGG TRIM, LTRIM, RTRIM, LEFT, RIGHT REPLACE REPLICATE REVERSE TRANSLATE STUFF SUBSTRING LOWER and UPPER Issues Resolved: BABEL-5337 Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
…ecated_object() Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While fixing issue in string functions for input containing multibyte characters, we blocked string functions called with some datatypes to be more compliance with TSQL, which were supported earlier by using underlying PostgreSQL string functions. This PR include changes to allow all string functions to be called on all the datatypes that were support earlier.
Following are the string functions which faced this issue and will be fixed with this PR:-
Cherry-picked from PR: #3192
Issues Resolved
BABEL-5337
Test Scenarios Covered
Use case based - YES
Boundary conditions - YES
Arbitrary inputs - NA
Negative test cases - NA
Minor version upgrade tests - NA
Major version upgrade tests - NA
Performance tests - NA
Tooling impact - NA
Client tests - YES
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.