Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators should stop submitting BLS-sigs when they are syncing #182

Closed
gitferry opened this issue Oct 31, 2022 · 3 comments
Closed

Validators should stop submitting BLS-sigs when they are syncing #182

gitferry opened this issue Oct 31, 2022 · 3 comments
Assignees

Comments

@gitferry
Copy link
Contributor

When a validator is syncing, it will relay all the history transactions including the ones sending BLS-sig transactions that have been sent already. It will cause unnecessary gas costs and unpredictable errors. So we should disable BLS submission when the validator is syncing.

@gitferry gitferry self-assigned this Oct 31, 2022
@gitferry
Copy link
Contributor Author

After some investigation, it seems that in the application layer (cosmos-sdk), we don't know whether the node (Tendermint) is syncing. This issue will be naturally solved after ABCI++ is upgraded as BLS signatures will be no longer in blocks as transactions. Should we close this issue now? cc @vitsalis

@vitsalis
Copy link
Member

Yep, agreed. When do we expect ABCI++ to become available?

@gitferry
Copy link
Contributor Author

It's a good question but tbh I'm not sure about that, especially given the recent drama that happened to Tendermint. But I found this. It seems that ABCI 2.0 (ABCI++) would be in version 0.38.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants