Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.19 #227

Closed
faddat opened this issue Nov 28, 2022 · 0 comments · Fixed by #257
Closed

go 1.19 #227

faddat opened this issue Nov 28, 2022 · 0 comments · Fixed by #257

Comments

@faddat
Copy link
Contributor

faddat commented Nov 28, 2022

So, basically there are differences in the output of the go 1.18 runtime vs 1.19, specifically with regard to crypto libs.

In the world of validator sets, this can break down into apphash errors.

Since some validators will use go 1.18, and some go 1.19, it makes sense to set go 1.19 in go.mod because then go1.19 is required to build and you end up with only a single go runtime, and you don't run into the same errors that would otherwise occur with mixed runtimes. Setting to go 1.18 still allows for validators to mix and... they will, so that's the reasoning behind using go 1.19 out of the gate, despite the fact that the cosmos-sdk v0.46.x uses go 1.18. (all validators will need to use go 1.19)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant