Bump golang to 1.19 #257
Merged
Bump golang to 1.19 #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
approved these changes
Dec 29, 2022
|
not sure what you mean by side effect but go is pretty strict it terms of backwards compatibility so everything should be fine. Ultimately it mostly means that Babylon will buildable only by 1.19 go compiler (a explained in attached issue) which is a bit of simplification. One minor side effect is that if someone (from eng team) have been using 1.18 to build/test/run Babylon locally will need to update go. (I have been using Go 1.19 from quite some time) |
vitsalis
added a commit
to babylonchain/vigilante
that referenced
this pull request
Jan 2, 2023
Given that the babylon repository is getting [bumped to Go 1.19](babylonchain/babylon#257), we should upgrade this one (as well as others).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #227