btcutils: refactor for vigilante #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
KonradStaniec
approved these changes
Aug 30, 2022
x/btccheckpoint/types/spv.go
Outdated
| ) | ||
|
|
||
| func SpvProofFromHeaderAndTransactions(headerBytes []byte, transactions [][]byte, transactionIdx uint) (*btcctypes.BTCSpvProof, error) { | ||
| func SpvProofFromHeaderAndTransactions(headerBytes []byte, transactions [][]byte, transactionIdx uint) (*BTCSpvProof, error) { |
There was a problem hiding this comment.
maybe move other spv stuff i.e createBranch and CreateProofForIdx as those things are related to spv ? also maybe leave some TODO here that this implementation will need some tests and maybe benchmarking. (you know it was used only for testing purposes and now will be part of public api so probably more scrunity is needed here)
vitsalis
added a commit
that referenced
this pull request
Jan 21, 2024
--------- Co-authored-by: Runchao Han <me@runchao.rocks>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors some BTC utils in order to simplify the development of vigilante reporter.
Specifically, this PR
BabylonDatapublicextractOpReturnDatapublicSpvProofFromHeaderAndTransactionsfromdatagentobtccheckpoint/types/in order to make them reusable for babylonchain/vigilante#8