Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epoching: bugfix of LatestEpochMsgs API #140

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

SebastianElvis
Copy link
Member

Fixes BM-173

This PR fixes a bug reported by @toliujiayi on calculating the interval of requested epochs given end_epoch and epoch_count.

Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -75,7 +75,7 @@ message QueryEpochMsgsResponse {
}

// QueryLatestEpochMsgsRequest is request type for the Query/LatestEpochMsgs RPC method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// QueryLatestEpochMsgsRequest is request type for the Query/LatestEpochMsgs RPC method
// QueryLatestEpochMsgsRequest is the request type for the Query/LatestEpochMsgs RPC method

Copy link
Contributor

@toliujiayi toliujiayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@SebastianElvis SebastianElvis merged commit 1d3386e into main Sep 14, 2022
@SebastianElvis SebastianElvis deleted the epoching-fix-epochmsg-query branch September 14, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants