Improve integration tests #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradStaniec
force-pushed
the
improve-integration-tests
branch
from
4dc5c26
to
871117c
Compare
KonradStaniec
force-pushed
the
improve-integration-tests
branch
from
91fb28a
to
d2118d7
Compare
aakoshh
reviewed
Oct 4, 2022
test/integration_test.go
Outdated
| t.Errorf("Epoch after 10 blocks, should equal 2. Curent epoch %d", currentEpochResponse.CurrentEpoch) | ||
| currentEpoch := getCurrentEpoch(c) | ||
| if currentEpoch != 2 { | ||
| t.Errorf("Epoch after 7 blocks, should equal 2. Curent epoch %d", currentEpoch) |
There was a problem hiding this comment.
Suggested change
| t.Errorf("Epoch after 7 blocks, should equal 2. Curent epoch %d", currentEpoch) | |
| t.Errorf("Epoch after 7 blocks, should equal 2. Current epoch %d", currentEpoch) |
Maybe you can also mention that this is because of the Makefile passing a flag?
aakoshh
reviewed
Oct 4, 2022
test/utils.go
Outdated
|
|
||
| acc, err := b.getAccount() | ||
| if err != nil { | ||
| panic("creating new header message must success ") |
There was a problem hiding this comment.
Suggested change
| panic("creating new header message must success ") | |
| panic("creating new header message must succeed") |
aakoshh
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve integration test:
Another way would be to add some retries, but that would make tests more non-detetministic.
Having those improvements halfs the current tests runtime.