feat: add validate-genesis cmd #187
Conversation
gitferry
force-pushed
the
genesis/validate-genesis
branch
from
38f1592
to
c942adc
Compare
cmd/babylond/cmd/validate_genesis.go
Outdated
| // validation rule | ||
| // 2. each genesis BLS key or gentx should have a corresponding gentx or genesis | ||
| // BLS key | ||
| // modified based on "github.com/cosmos/cosmos-sdk/x/genutil/client/cli/validate_genesis.go" |
There was a problem hiding this comment.
This link does not lead to a file. Note to also use the commit in the link instead of a tag/branch
| } | ||
| if len(addresses) != len(gks) { | ||
| return errors.New("duplicate genesis BLS keys") | ||
| } |
There was a problem hiding this comment.
Since you check that on the Validate function of the checkpointing module, you don't need to do it again here as the ValidateFunction already gets called.
There was a problem hiding this comment.
It is true, but I just thought CheckCorrespondence is rather independent. It does not hurt if we do the length checking here again. What if some day we accidentally move CheckCorrespondence before the module validation?
| if len(addresses) != len(gks) { | ||
| return errors.New("duplicate genesis BLS keys") | ||
| } | ||
| if len(addresses) != len(genTxState.GenTxs) { |
There was a problem hiding this comment.
This check means that you don't have to do a reverse loop later to check whether all BLS sigs have a matching gentx, right? Maybe worth adding a comment about your checking algorithm.
cmd/babylond/cmd/validate_genesis.go
Outdated
| } | ||
| msgCreateValidator := msgs[0].(*stakingtypes.MsgCreateValidator) | ||
| if _, exists := addresses[msgCreateValidator.ValidatorAddress]; !exists { | ||
| return errors.New("genesis txs and genesis BLS keys do not match") |
There was a problem hiding this comment.
Maybe give details about what is not matching? Also, maybe say that there is no BLS key for the gentx.
| "testing" | ||
| ) | ||
|
|
||
| var misMatchGenesis = ` |
There was a problem hiding this comment.
Could those structures be created in a programmatic manner? Would make this a bit cleaner.
cmd/babylond/cmd/validate_genesis.go
Outdated
| "github.com/babylonchain/babylon/x/checkpointing/types" | ||
| ) | ||
|
|
||
| const chainUpgradeGuide = "https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md" |
There was a problem hiding this comment.
The main branch here is going to change over time. This should point to an unchangeable link to the version that we are using.
|
Thanks, @vitsalis for your suggestions. To generate genesis docs for testing in a programmatic manner, I exported |
This PR adds
validate-genesiscommand. The implementation is adapted from the originalvalidate-genesiscommand. The additional check is about the correspondence of genesis txs and genesis BLS keys. The example of using the command is as follows.