zoneconcierge: API for listing all chain IDs #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
approved these changes
Nov 21, 2022
|
|
||
| ctx := sdk.UnwrapSDKContext(c) | ||
| chainIDs := k.GetAllChainIDs(ctx) | ||
| resp := &types.QueryChainListResponse{ChainIds: chainIDs} |
There was a problem hiding this comment.
Maybe add pagination? If it requires too much time we can add a github issue and add it later.
There was a problem hiding this comment.
Given the time constraint and the project's status, I added a TODO on this. Thanks for pointing this out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the API for querying IDs of all chains that checkpoint to Babylon. It comes with a fuzz test.
After this PR, all APIs for level 1 integration are ready.