zoneconcierge: add checkpoint info and epoch info to FinalizedChainInfo API
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianElvis
changed the title
FinalizedChainInfo APIFinalizedChainInfo API
vitsalis
approved these changes
Nov 22, 2022
|
|
||
| ctx := babylonChain.GetContext() | ||
| czChainID := string(datagen.GenRandomByteArray(10)) |
There was a problem hiding this comment.
What's the expected size of the chain id? We can have this a random string in the range of [1,50] for example.
There was a problem hiding this comment.
Normally ~10bytes. Randomised the length then.
Closed
| err := fmt.Errorf("finalized epoch %d should have at least 1 checkpoint submission", finalizedEpoch) | ||
| panic(err) | ||
| } | ||
| bestSubmissionKey := ed.Key[0] |
There was a problem hiding this comment.
just fyi without #204, this will not necessarily return best submission key (i.e the deepest one) but it will return the submission which was first subbmitted to babylon. (cc @SebastianElvis )
There was a problem hiding this comment.
Yep. I merged this PR due to the time constraint. Will simplify this part based on #204 in the future 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://babylon-chain.atlassian.net/wiki/spaces/BABYLON/pages/41549900/Simple+Oracle+Page+for+Demo+Purpose?focusedCommentId=41910291
This PR adds the information of the checkpoint/epoch w.r.t. the finalised header to
FinalizedChainInfo. The checkpoint information is in typeSubmissionKeythat provides the positions of two BTC txs and is implemented in BTCCheckpoint module. The epoch information is in typeEpochand is implemented in Epoching module.Along the way, this PR also changes the order of initialising keepers in
app.goand adds some mocking functionality for testing ZoneConcierge.@KonradStaniec Do you think #204 will be useful for this PR?