-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zoneconcierge: debugging API ChainInfo
#211
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
80d4217
init
SebastianElvis 9d9cd19
init
SebastianElvis 8ce3dc9
minor
SebastianElvis 9f41837
add epoching dep to zc
SebastianElvis c833b50
Merge branch 'zoneconcierge-api-fixes' into zoneconcierge-api-debug-c…
SebastianElvis d89cd82
Merge branch 'dev' into zoneconcierge-api-fixes
SebastianElvis 645cbac
Merge branch 'zoneconcierge-api-fixes' into zoneconcierge-api-debug-c…
SebastianElvis 580db22
randomise chain id len
SebastianElvis 6882b45
Merge branch 'zoneconcierge-api-fixes' into zoneconcierge-api-debug-c…
SebastianElvis 525ce68
Merge branch 'dev' into zoneconcierge-api-debug-chaininfo
SebastianElvis 267899b
minor
SebastianElvis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we add further attributes here as with
QueryFinalizedChainInfoResponse
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, epoch info and btc checkpoint info would be super useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this API is only for debugging, it would be overkill to add stuff like inclusion proofs to this API. At the moment as long as the query gives us latest chain info then it should be enough for debugging.
Such a latest chain info can be in an epoch that hasn't ended yet. To have these info the epoch with this chain info has to be at least submitted.