FIX: Failing btclightclient tests, remove unneeded ones, clean up #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
approved these changes
Jun 21, 2022
KonradStaniec
pushed a commit
that referenced
this pull request
Oct 25, 2023
* proto files * list btc vals * btc vals query * rename rpc * query methods * more rpc * fix proto * fix proto * fix proto * fix lint * add pagination * fix * fix imports * fix err * fix str * Update proto/babylon/btcstaking/v1/query.proto Co-authored-by: Runchao Han <me@runchao.rocks> * fix pr comments * rename * fix lint * fix bytes in req * fix del start/end ht * remove sentinel err * fix str --------- Co-authored-by: Runchao Han <me@runchao.rocks>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several minor changes bundled into one:
btclightclientTODOcomments pointing where to add new module boilerplate code.app/app_test.go. Those tests where included whenConsensusVersion()was upgraded from1to2and the test checks whether the migrations are performed properly for the modules that were updated. We start off with version2so no migrations exist for us and we shouldn't re-test what cosmos already tests.You can test the updates with
make test