feat: Add bls pubkey set api #232
Conversation
| end = total | ||
| } | ||
| var copiedValBLSKeys []*types.ValidatorWithBlsKey | ||
| err = copier.Copy(&copiedValBLSKeys, valBLSKeys[start:end]) |
There was a problem hiding this comment.
Why do we want to copy it rather than using the slice directly?
There was a problem hiding this comment.
We want a deep copy since we don't want the passed slice to be affected by the original one. But, in this specific case, we do not need to copy it
| } | ||
|
|
||
| total := uint64(len(valBLSKeys)) | ||
| start := req.Pagination.Offset |
There was a problem hiding this comment.
I remember Cosmos SDK provides functionalities for getting the paginated response given a pagination request, e.g., something like https://github.com/babylonchain/babylon/blob/dev/x/epoching/keeper/grpc_query.go#L67-L92
There was a problem hiding this comment.
Yeah, thanks for the pointer. Thing is that the set is obtained from epoching store and sorted. I'm not sure how to use this functionality in our case
| ek := helper.EpochingKeeper | ||
| ck := helper.App.CheckpointingKeeper | ||
| querier := checkpointingkeeper.Querier{Keeper: ck} | ||
| queryHelper := baseapp.NewQueryServerTestHelper(helper.Ctx, helper.App.InterfaceRegistry()) | ||
| types.RegisterQueryServer(queryHelper, querier) | ||
| queryClient := types.NewQueryClient(queryHelper) | ||
| msgServer := checkpointingkeeper.NewMsgServerImpl(ck) |
There was a problem hiding this comment.
It seems that L28-34 will be used quite frequently. Maybe they can be a part of the response of testepoching.NewHelper?
There was a problem hiding this comment.
Would that be strange that we have checkpointing stuff inside an epoching test helper? I have thought about having a helper specifically for checkpointing, but I think that would be a little bit heavy for now
| Pagination: &query.PageRequest{ | ||
| Offset: 1, | ||
| }, |
There was a problem hiding this comment.
Great, you even have a test for the pagination 👍
This PR added BLS public key set query. Adding this is for the Verifier to verify BTC raw checkpoints.