zoneconcierge: query inclusion proofs and add them to ProofEpochSealed
#243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
Dec 13, 2022
| ) | ||
|
|
||
| func getEpochInfoKey(epochNumber uint64) []byte { |
There was a problem hiding this comment.
Would it be cleaner if we move this function to x/zoneconcierge/types/keys.go?
There was a problem hiding this comment.
This is possible. However, my concern is that if we do this, then the function has to be public to any module that imports zoneconciergetypes. This might be too open. I thus chose to make this function and the below getValSetKey as private functions. If other modules under zoneconcierge need to use them in the future, I will move them to x/zoneconcierge/types/keys.go. 👍
| return proof, nil | ||
| } | ||
|
|
||
| func getValSetKey(epochNumber uint64) []byte { |
| return epochInfoKey | ||
| } | ||
|
|
||
| func (k Keeper) ProveEpochInfo(ctx sdk.Context, epoch *epochingtypes.Epoch) (*tmcrypto.ProofOps, error) { |
There was a problem hiding this comment.
It seems that ctx is not used. Do we still want to keep it?
| return valSetKey | ||
| } | ||
|
|
||
| func (k Keeper) ProveValSet(ctx sdk.Context, epoch *epochingtypes.Epoch) (*tmcrypto.ProofOps, error) { |
| // ProveEpochSealed proves an epoch has been sealed, i.e., | ||
| // - the epoch's validator set has a valid multisig over the sealer header | ||
| // - the epoch's validator set is committed to the sealer header's last_commit_hash | ||
| // - the epoch's metadata is committed to the sealer header's last_commit_hash | ||
| func (k Keeper) ProveEpochSealed(ctx sdk.Context, epochNumber uint64) (*types.ProofEpochSealed, error) { | ||
| var ( | ||
| proof *types.ProofEpochSealed = &types.ProofEpochSealed{} |
There was a problem hiding this comment.
Suggested change
| proof *types.ProofEpochSealed = &types.ProofEpochSealed{} | |
| proof = &types.ProofEpochSealed{} |
| } else { // BLS sig has a valid quorum | ||
| require.Greater(t, subsetPower, valSet.GetTotalPower()*1/3) | ||
| require.NoError(t, err) | ||
| require.True(t, sdkerrors.IsOf(zctypes.ErrInvalidMerkleProof, err)) |
There was a problem hiding this comment.
Suggested change
| require.True(t, sdkerrors.IsOf(zctypes.ErrInvalidMerkleProof, err)) | |
| require.ErrorIs(t, err, zctypes.ErrInvalidMerkleProof) |
| @@ -92,9 +94,30 @@ func FuzzProofEpochSealed(f *testing.F) { | |||
| if numSubSet <= numVals*1/3 { // BLS sig does not reach a quorum | |||
| require.LessOrEqual(t, subsetPower, uint64(numVals*1/3)) | |||
| require.Error(t, err) | |||
| require.False(t, sdkerrors.IsOf(zctypes.ErrInvalidMerkleProof, err)) | |||
There was a problem hiding this comment.
Suggested change
| require.False(t, sdkerrors.IsOf(zctypes.ErrInvalidMerkleProof, err)) | |
| require.NotErrorIs(t, err, zctypes.ErrInvalidMerkleProof) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BM-303
This PR implements the functionalities for querying inclusion proofs to Cosmos SDK's underlying DB. The query is done by using the
sdk.Querierinterface implemented by Cosmos SDK's underlying DB (in typestore.CommitMultiStore). This PR also contains a fuzz test for it.Given this functionality, this PR implements the inclusion proofs for the epoch metadata and the validator set in `ProofEpochSealed.
Future works