zoneconcierge: fix flaky test FuzzProofEpochSealed_BLSSig
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradStaniec
approved these changes
Dec 23, 2022
SebastianElvis
deleted the
zoneconcierge-fix-fuzzproofepochsealed-bls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
This PR fixes a flaky test
FuzzProofEpochSealed_BLSSig. The test ensures that a BLS sig with a quorum can pass verification, otherwise it cannot. The test was flaky because checking whether a BLS sig has a quorum via comparing number of signed validators rather than voting power. Since each validator has 1000 voting power according todatagen.GenerateValidatorSetWithBLSPrivKeys, measuring quorum via voting power is more precise than via number of validators.