zoneconcierge API: adding total number of timestamped headers to chainInfo #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
approved these changes
Jan 9, 2023
| func (k Keeper) updateLatestHeader(ctx sdk.Context, chainID string, header *types.IndexedHeader) error { | ||
| if header == nil { | ||
| return sdkerrors.Wrapf(types.ErrInvalidHeader, "header is nil") | ||
| } | ||
| chainInfo := k.GetChainInfo(ctx, chainID) | ||
| chainInfo.LatestHeader = header | ||
| chainInfo.LatestHeader = header // replace the old latest header with the given one | ||
| chainInfo.TimestampedHeadersCount++ // increment the number of timestamped headers |
There was a problem hiding this comment.
It would be worth it to add a comment that this involves only the headers that we receive and not all headers that are in between submissions. For example, given the current IBC implementation if we receive header at height N and then the next one at height N+k, this number will be 2 and not k
KonradStaniec
added a commit
that referenced
this pull request
Jan 12, 2023
* zoneconcierge: API for querying the chain info of a given epoch (#260) * zoneconcierge: API for querying headers in a given epoch (#261) * zoneconcierge API: adding total number of timestamped headers to chainInfo (#263) * zoneconcierge API: find the BTC-finalised chain info before specific CZ height (#264) * zoneconcierge API: find header and fork headers at a given height (#266) * checkpointing API: add checkpoint lifecycle in `RawCheckpointWithMeta` (#267) * chore: refactor `FinalizedChainInfo` API (#268) * Add integration test for zoneconcierge checkpointing (#269) * Add integration test checking info about opposing cz chain * Fix: Increase gas in e2e test (#270) Increase gas * fix: checkpointing: Do not make the `home` flag a required one and unmarshall PubKey (#271) * Fix build Co-authored-by: Runchao Han <me@runchao.rocks> Co-authored-by: Vitalis Salis <VitSalis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BE-16
This PR adds an extra field
TimestampedHeadersCounttoChainInfoin order to track the total number of timestamped headers for a given CZ. This allows the explorer to give statistics of CZs, as proposed in https://babylon-chain.atlassian.net/wiki/spaces/BABYLON/pages/50955614/The+Oracle#2.2-The-Timestamp-Finder-Tab.Along the way this PR also adds some comments to document the functions.