epoching/checkpointing: fuzz test for validators with zero voting power #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
Jan 16, 2023
| @@ -19,6 +20,82 @@ import ( | |||
| "github.com/tendermint/tendermint/crypto/ed25519" | |||
| ) | |||
|
|
|||
| // FuzzWrappedCreateValidator_InsufficientTokens tests adding new validators with zero voting power | |||
| // It ensures that validators with zero voting power (i.e., with tokens fewer than sdk.DefaultPowerReduction) | |||
| // are unbonded, thus are not included in the validator | |||
There was a problem hiding this comment.
Suggested change
| // are unbonded, thus are not included in the validator | |
| // are unbonded, thus are not included in the validator set |
vitsalis
approved these changes
Jan 16, 2023
| require.Equal(t, uint64(1), epoch.EpochNumber) | ||
|
|
||
| n := rand.Intn(3) + 1 | ||
| addrs := app.AddTestAddrs(helper.App, helper.Ctx, n, sdk.NewInt(100000000)) |
There was a problem hiding this comment.
Should we specify sdk.DefaultPowerReduction here instead of the literal?
There was a problem hiding this comment.
This is the amount of tokens for each genesis account rather than that for each validator, so it should be some large values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #275
This PR provides a fuzz test ensuring validators with zero voting power are unbonded and are not included in the validator set. In the reported issue, the validator has only
100000tokens, while 1 voting power takes at leastsdk.DefaultPowerReduction(1000000) tokens. Thus the behaviour is in fact expected.During debugging, I also fixed some TODOs on moving stuff from epoching to checkpointing.