fix: API/Fix checkpoint list total error #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
approved these changes
Jan 17, 2023
| req := types.NewQueryRawCheckpointListRequest(pagination, status) | ||
|
|
||
| for ckptsRetrieved := uint64(0); ckptsRetrieved < uint64(len(checkpointList)); ckptsRetrieved += limit { | ||
| resp, err := ckptKeeper.RawCheckpointList(ctx, req) | ||
| require.NoError(t, err) | ||
| if ckptsRetrieved == 0 { | ||
| require.Equal(t, uint64(len(checkpointList)), resp.Pagination.Total) |
There was a problem hiding this comment.
Given that this check happens only once, maybe it can happen outside of the loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the total error in pagination of the response of
RawCheckpointList. Before the fix, when Finalized checkpoints are requested, thetotalin the pagination of the response is the total number of all the checkpoints instead of only finalized ones. This PR fixed the bug and added relevant test.