Update protobuf generation #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianElvis
approved these changes
Mar 5, 2023
| @@ -8,7 +8,6 @@ BINDIR ?= $(GOPATH)/bin | |||
| BUILDDIR ?= $(CURDIR)/build | |||
| HTTPS_GIT := https://github.com/babylonchain/babylon.git | |||
| DOCKER := $(shell which docker) | |||
| DOCKER_BUF := $(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace bufbuild/buf | |||
There was a problem hiding this comment.
it was not used anywhere, also all buf usage comes from protoImage
| @@ -43,37 +43,35 @@ message BTCSpvProof { | |||
| // which transaction was included and transaction index in the block | |||
| message TransactionKey { | |||
| uint32 index = 1; | |||
| bytes hash = 2 [ | |||
| (gogoproto.customtype) = "github.com/babylonchain/babylon/types.BTCHeaderHashBytes" | |||
There was a problem hiding this comment.
If I understand correctly, this format is enforced by proto-lint, right?
There was a problem hiding this comment.
this is mostly from proto-format. Currently it uses default config but if we will find some formatting weird we will be able to adjust it it in the future
Sounds like good idea, maybe we can disscus it on our next sprint planning meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various cleanups in our protobufs:
x/epoching/types/message.pb.goproto file which was with us from the start of the projectI have also for now turned off a lot of linter rules regarding comments in proto files, as our protos are definitly under documented 😅
Rules I am talking about are:
Imo we should decide which of those rules we want to enforce , and then everybody should pick one module and add proper docs, then we can re-enable this rules.