Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new version for our fork of ibc go #332

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Use new version for our fork of ibc go #332

merged 1 commit into from
Mar 23, 2023

Conversation

KonradStaniec
Copy link
Contributor

New version has been simplified due to usage of ibc-go v7
New version can work with other types of light clients not only tendermint

New version has been simplified due to usage of ibc-go v7
New version can work with other types of light clients
not only tendermint
Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

A random idea: is it feasible to move the ExtendedKeeper from IBC-Go fork repo to Babylon? such that the modifications in IBC-Go fork are made minimal and we can update stuff related to this hook within a single PR

@KonradStaniec
Copy link
Contributor Author

A random idea: is it feasible to move the ExtendedKeeper from IBC-Go fork repo to Babylon? such that the modifications in IBC-Go fork are made minimal and we can update stuff related to this hook within a single PR

yup I was actually thinking about it.

I think the only thing that needs to live in fork repo is introducing keeper interface and using it in tests and necessary places. ExtendedKeeper implementation and hooks can be moved to our babylon repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants