Move checkpoint tag to params #356
Conversation
KonradStaniec
commented
Apr 21, 2023
•
KonradStaniec
commented
- moves checkpoint tag to params
- make checkpoint tag hex encoded string at babylon node level. It is job of some high level protocols to give those bytes a meaning.
- removes file with default tags
There was a problem hiding this comment.
Very clean! As we discussed offline, it would be nice if the BTC network was also moved to params as well, but given that the btccheckpoint module also needs to verify the work of headers as it receives them, this is not entirely straightforward. One case in which we could keep this feature (i.e. btccheckpoint receives headers as well) would be that the module doesn't do any PoW checks itself, but instead just forwards the header and the btclightclient module performs the check, returning error if it's not valid. We can further discuss this as a future optimization.
testutil/datagen/btc_transaction.go
Outdated
| @@ -375,9 +375,10 @@ func GenRandomBabylonTxPair() ([]*wire.MsgTx, *btctxformatter.RawBtcCheckpoint) | |||
|
|
|||
| // fake a raw checkpoint | |||
| rawBTCCkpt := GetRandomRawBtcCheckpoint() | |||
| tag := []byte{1, 2, 3, 4} | |||
There was a problem hiding this comment.
| tag := []byte{1, 2, 3, 4} | |
| tag := datagen.GenRandomByteArray(4) |
will resolve the TODO below.
x/btccheckpoint/keeper/params.go
Outdated
| @@ -14,7 +14,7 @@ func (k Keeper) SetParams(ctx sdk.Context, p types.Params) error { | |||
| store := ctx.KVStore(k.storeKey) | |||
| bz := k.cdc.MustMarshal(&p) | |||
| store.Set(types.ParamsKey, bz) | |||
|
|
|||
It would be doable, but it would require a bit of refactoring on |
