chore: circleci: Use image with go 1.20.3 installed #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.circleci/config.yml
Outdated
| machine: | ||
| image: ubuntu-2204:2022.10.1 | ||
| resource_class: large | ||
| docker: |
There was a problem hiding this comment.
Unfortunately for integration tests we are using and starting docker container, and last time I check it was impossible to do it in docker execution enviroment. That why we were always using https://circleci.com/docs/executor-intro/#linux-vm on babylon node side
There was a problem hiding this comment.
I changed this to install the correct go version in the docker image and it looks like we encounter no issues 🥳
|
Ok managed to resolve this using an orb, please check again! Also found a linting issue due to a deprecated method we did not find before due to using the incorrect golang version :) |
KonradStaniec
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the rpc-client repository I encountered issues due to the Ubuntu image being used having Go 1.18 installed instead of the 1.20 version that we use. These were fixed when I used an image with the appropriate version installed, so figured to do the same here.
Given that we use Docker for some of the build steps this fails. Will investigate further.