feat: new rpc RawCheckpoints #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusin13
force-pushed
the
BM-607-optimize-raw-checkpoint-rpc
branch
from
4558e01
to
7824663
Compare
gusin13
changed the base branch from
BM-603-api-add-new-rpc-queries-finalized
to
dev
gusin13
force-pushed
the
BM-607-optimize-raw-checkpoint-rpc
branch
from
a37569c
to
cd3081b
Compare
gusin13
force-pushed
the
BM-607-optimize-raw-checkpoint-rpc
branch
from
f3e78bf
to
5874e85
Compare
vitsalis
approved these changes
May 4, 2023
| @@ -24,6 +24,13 @@ service Query { | |||
| "/babylon/checkpointing/v1/raw_checkpoint/{epoch_num}"; | |||
| } | |||
|
|
|||
| // RawCheckpoints queries a checkpoints at a given epoch number. | |||
There was a problem hiding this comment.
There's no epoch number in the request.
There was a problem hiding this comment.
sure, was a typo, fixed now
|
|
||
| var checkpointList []*types.RawCheckpointWithMeta | ||
| pageRes, err := query.Paginate(store, req.Pagination, func(key, value []byte) error { | ||
| ckptWithMeta, err := types.BytesToCkptWithMeta(k.cdc, value) |
There was a problem hiding this comment.
BytesToCkptWithMeta unmarshals, its used in other places in code as well so used the same.
There was a problem hiding this comment.
changed to MustUnmarshal as per our offline discussion.
Co-authored-by: Vitalis Salis <VitSalis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of optimizations done to improve babylon-api performance.
The explorer calls
RawCheckpointrpc multiple times for each epoch. I have added a new rpcRawCheckpointswhich can ingest a range of epochs using pagination params.Testing
Added fuzz, e2e tests and cli queries.