zoneconcierge: adding header timestamp to IndexedHeader #387
Conversation
| // time is the timestamp of this header on CZ ledger | ||
| // it is needed for CZ to unbond all mature validators/delegations | ||
| // before this timestamp when this header is BTC-finalised | ||
| google.protobuf.Timestamp time = 4 [ (gogoproto.stdtime) = true ]; |
There was a problem hiding this comment.
In our own modified staking we only use the block and we retrieve time from there. Why do we need to add the time here? Can you provide an example of how this is going to be used?
There was a problem hiding this comment.
In our own modified staking we only use the block and we retrieve time from there.
Yes this is because Babylon checkpoints itself to Bitcoin and has access to the epoch boundary header (including height and time).
Why do we need to add the time here? Can you provide an example of how this is going to be used?
The situation is a bit different in the CZ side (I realised this during developing Babylon contract). The ApplyMatureUnbonding function in CZ side needs to use both height and time, which can only come from BTC-finalised IndexedHeader. However, The IndexedHeader does not have time at the moment. The current Babylon contract uses time of the Babylon header that timestamps this CZ header, which is not accurate.
This PR adds the CZ header's timestamp to
IndexedHeader. It's needed for phase 3 integration, namely notifying CZ to unbond mature validators before this timestamp.